Goods (such as shoes) are tangible products. Services (such as repairing computers) are intangible products. Both goods and services are products. Thus, the general rule is that revenue from a product is recognized when the product is [manufactured / contracted for / delivered].